Repository navigation
test(net): skip only the IPv6 socket checks on a host without IPv6 - #2251
Merged
oneandonlydean merged 1 commit intoOct 9, 2026
Merged
Conversation
On a host without IPv6, socket(AF_INET6) fails with EAFNOSUPPORT, so guest_sce_net aborted at its first IPv6 socket and never ran the TCP, UDP, epoll, sendmsg/recvmsg, resolver and NetCtl checks after it. When sceNetSocket reports guest EAFNOSUPPORT (47) for the IPv6 socket, skip those socket checks, run the rest of the test, and exit with 77, which ctest reports as skipped. Hosts with IPv6 run every check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ha6Tsy62AFUyp9a5Mf7vjA
MarcZX10
approved these changes
Oct 9, 2026
MarcZX10
left a comment
MarcZX10
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the full diff and reran Conventions on the exact head. The skip is limited to the IPv6 socket checks after guest EAFNOSUPPORT (47); IPv6 address text checks and the remaining IPv4, TCP, UDP, resolver, epoll, message, and NetCtl checks still execute. CTest maps only this test's 77 exit to skipped. The PR reports a full 513-test run with this change applied and a reproduction on a host without IPv6. No blocking issues found.
Contributor
|
Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head
No title was run. 🤖 Addressed by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a host whose kernel has no IPv6,
socket(AF_INET6)fails withEAFNOSUPPORT, soguest_sce_netaborted at its first IPv6 socket inCheckUnspecifiedIpv6and never ran the TCP, UDP, epoll,sceNetSendmsg/sceNetRecvmsg, resolver and NetCtl checks after it.When
sceNetSocketreports guestEAFNOSUPPORT(47) for the IPv6 socket, the test now skips those IPv6 socket checks, runs the rest, and exits with 77, which ctest reports as skipped (SKIP_RETURN_CODE 77, asguest_video_out_wqhd_detectiondoes). The IPv6 address-text checks still run. Hosts with IPv6 run every check as before.Tested
Ubuntu 24.04 container whose kernel has no IPv6 (
/proc/net/if_inet6absent): before,guest_sce_netaborted (Subprocess aborted); after, every other check runs and passes and ctest reports it as Skipped. The IPv6 path cannot be run there; on a host with IPv6 the added branch is not taken, so CI runs the same checks as before. Fullctest --parallel 4 --timeout 120ond70b8998with this change and the two other fixes applied: 513 tests, 0 failures.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt (n/a).mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code
https://claude.ai/code/session_01Ha6Tsy62AFUyp9a5Mf7vjA